Add trusted-publish #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaborbernat
force-pushed
the
all-repos_autofix_trusted-publish-2023-04-26
branch
from
c3fe8ff
to
bcc400e
Compare
webknjaz
reviewed
Feb 3, 2024
| with: | ||
| fetch-depth: 0 | ||
| - name: Build package | ||
| run: pyproject-build -s -w . -o dist |
There was a problem hiding this comment.
@gaborbernat FYI this place is an attack surface targeting OIDC as it can potentially be used to reach other things than PyPI. The attack vector is the build deps poisoning, followed by the privilege elevation. This is why I always recommend building in a separate job that does not have access to OIDC.
There was a problem hiding this comment.
I don't see how that helps. The token is scoped to this project only. If the user has hijacked the build chain, they cannot upload a new package themselves, however a package upload will happen anyway as part of the release pipeline, so they can just alter the build output and, in essence, upload whatever they want.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Committed via https://github.com/asottile/all-repos