Fix unnecessary newline addition on sub-tables #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you add a test that for this new case if there's no newline we add it? |
|
Try that! |
gaborbernat
reviewed
Feb 16, 2023
| content = """ | ||
| [tool.mypy] | ||
| a = 0 | ||
|
|
There was a problem hiding this comment.
Can we remove this newline too here 😅
There was a problem hiding this comment.
Oh, I see why you did not do it. 🤔 If you remove this line this patch will not add the newline in.
Closed
|
I've pushed an ignore for the coverage issue ( nedbat/coveragepy#1480 ). We could make pyproject-fmt format all space between tables and sub-tables, but perahps first release this to fix the bug? |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #69.