Configure pyproject-fmt options from pyproject.toml file
#169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edgarrmondragon
force-pushed
the
130-configure-from-pyproject
branch
from
c44c334
to
0c7adea
Compare
|
I'm not a fan of the config being read from each of the input |
edgarrmondragon
force-pushed
the
130-configure-from-pyproject
branch
from
0c7adea
to
49cc12e
Compare
gaborbernat
requested changes
Jan 21, 2024
| @@ -29,6 +29,9 @@ def format_pyproject(conf: Config) -> str: | |||
| :return: the formatted text | |||
| """ | |||
| parsed: TOMLDocument = parse(conf.toml) | |||
| overrides = parsed.get("tool", {}).get("pyproject_fmt", {}) | |||
There was a problem hiding this comment.
I think we should use - instead of _ in the name.
edgarrmondragon
force-pushed
the
130-configure-from-pyproject
branch
from
371d07c
to
4cb27a7
Compare
gaborbernat
approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #130