CLI: Accept --version argument, to print the package version
#139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amotl
force-pushed
the
amo/cli-add-version
branch
from
f22f83b
to
4a7b5eb
Compare
amotl
force-pushed
the
amo/cli-add-version
branch
from
4a7b5eb
to
31b5ff1
Compare
amotl
force-pushed
the
amo/cli-add-version
branch
from
31b5ff1
to
d194ecb
Compare
Apologies. It worked on my machine. I will have a look. |
amotl
force-pushed
the
amo/cli-add-version
branch
from
d194ecb
to
308bd03
Compare
amotl
commented
Oct 24, 2023
amotl
force-pushed
the
amo/cli-add-version
branch
2 times, most recently
from
897b269
to
a63df55
Compare
|
It looks like to works better now on CI. 🌻 |
gaborbernat
requested changes
Oct 24, 2023
tests/test_cli.py
Outdated
| cli_args(["--version"]) | ||
| assert context.value.code == 0 | ||
| out, err = capsys.readouterr() | ||
| assert out.startswith(("pytest", "__main__.py")) |
There was a problem hiding this comment.
Shouldn't this be pyproject-fmt? Perhaps we should set prog above.
There was a problem hiding this comment.
Also there's no assert that it prints out the correct version.
There was a problem hiding this comment.
Thank you.
a) The patch has been amended to define the prog parameter to ArgumentParser. Is it the right choice? If not, please educate me how to do it differently.
b) The test case has been adjusted to also verify the correct version number is actually used when printing to stdout.
amotl
force-pushed
the
amo/cli-add-version
branch
3 times, most recently
from
d3f0096
to
34119ba
Compare
This helps in debugging situations to find out about the installed version of `pyproject_fmt`.
amotl
force-pushed
the
amo/cli-add-version
branch
from
34119ba
to
0975a41
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi again,
using the
--versionargument helps in debugging situations to find out about the installed version ofpyproject-fmt.With kind regards,
Andreas.