Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

retry: Extend Policy trait documentation #690

Merged
merged 1 commit into from
Sep 12, 2022

Conversation

wutchzone
Copy link
Contributor

Last week I was debugging while my Retry service was not behaving as expected. I found out in the source code that if my Policy implementation returns None in clone_request, then the retry logic will not be called. I would like to mention this in the interface to save time for the folks that could probably debug the same behavior.

Copy link
Member

@LucioFranco LucioFranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@LucioFranco LucioFranco merged commit 4362dfc into tower-rs:master Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants