Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(keyBy): Accept number and symbol keys in keyBy #98

Merged
merged 1 commit into from
Jun 30, 2024

Conversation

mass2527
Copy link
Contributor

#93 (comment)

Make number and symbol keys acceptable for the keyBy function.

@mass2527 mass2527 requested a review from raon0211 as a code owner June 30, 2024 05:23
Copy link

vercel bot commented Jun 30, 2024

@mass2527 is attempting to deploy a commit to the Toss Team on Vercel.

A member of the Team first needs to authorize it.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (6c776a4) to head (8dfd875).
Report is 4 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##              main       #98   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           56        56           
  Lines          299       299           
  Branches        35        35           
=========================================
  Hits           299       299           

@raon0211 raon0211 changed the title feat(keyBy): Add support for number and symbol keys feat(keyBy): Accept number and symbol keys in keyBy Jun 30, 2024
@raon0211 raon0211 merged commit a9e317b into toss:main Jun 30, 2024
7 of 8 checks passed
Copy link

codspeed-hq bot commented Jun 30, 2024

CodSpeed Performance Report

Merging #98 will degrade performances by 88.78%

Comparing mass2527:feat/keyBy (8dfd875) with main (fc1a8e6)

Summary

⚡ 7 improvements
❌ 8 regressions
✅ 81 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main mass2527:feat/keyBy Change
lodash 326.9 µs 206.8 µs +58.07%
lodash/difference 218.2 µs 56.8 µs ×3.8
lodash/differenceBy 225.2 µs 345.5 µs -34.82%
lodash/differenceWith 223.5 µs 69.3 µs ×3.2
es-toolkit/intersection 2.8 ms 7.2 ms -60.85%
lodash/intersectionBy 324.3 µs 465.2 µs -30.28%
lodash/isNil 35.7 µs 318.1 µs -88.78%
es-toolkit/range 39.3 µs 48.4 µs -18.63%
lodash/range 33.6 µs 44.1 µs -23.87%
lodash/shuffle 195.6 µs 43 µs ×4.5
lodash/unionBy 230.1 µs 75.3 µs ×3.1
lodash/xorBy 267.7 µs 91 µs ×2.9
lodash/xorWith 405.8 µs 259.6 µs +56.32%
lodash/zip 243 µs 362.1 µs -32.9%
lodash/zipWith 261.4 µs 377.7 µs -30.8%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants