Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add convertQwertyToHangulAlphabet, disassembleCompleteHangulCha… #90

Merged
merged 2 commits into from
May 16, 2024

Conversation

youngjae99
Copy link
Contributor

@youngjae99 youngjae99 commented May 14, 2024

Overview

PR Checklist

  • I read and included theses actions below
  1. I have read the Contributing Guide
  2. I have written documents and tests, if needed.

@youngjae99 youngjae99 self-assigned this May 14, 2024
Copy link

changeset-bot bot commented May 14, 2024

🦋 Changeset detected

Latest commit: b8c47cc

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented May 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
es-hangul ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 16, 2024 2:18am

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.51%. Comparing base (11b6ab7) to head (90151f4).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #90   +/-   ##
=======================================
  Coverage   99.51%   99.51%           
=======================================
  Files          13       13           
  Lines         206      206           
  Branches       46       46           
=======================================
  Hits          205      205           
  Misses          1        1           

evan-moon
evan-moon previously approved these changes May 14, 2024
Copy link
Member

@evan-moon evan-moon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@okinawaa okinawaa merged commit 91a46a2 into toss:main May 16, 2024
2 of 3 checks passed
@github-actions github-actions bot mentioned this pull request May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants