fix: 인자로 빈 문자열이 들어올 경우 얼리리턴하도록 수정 #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 3d34ed3 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
okinawaa
reviewed
May 7, 2024
Comment on lines
+24
to
+28
| const lastChar = str[str.length - 1]; | ||
|
|
||
| if(lastChar == null) { | ||
| return false; | ||
| } |
There was a problem hiding this comment.
str자체가 빈 값일때 얼리 리턴해주는것과,
연산 결과값인 lastChar이 null일때 얼리 리턴해주는것과 차이가 있나요?!
if(str == null) {
return false;
}There was a problem hiding this comment.
str이 ''로 오는 경우엔 nullish하지 않아 '' == null이 성립되지 않습니다!
하지만 이때 lastChar는 undefined가 되어 조건에 성립하게 됩니다.
만약 str 값만 보고 얼리리턴을 해야한다면 요렇게 하면 될 것 같아용
if (str === '') {
return false;
}
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
[as-is]
hasBatchim과hasSingleBachim함수의 인자로''가 들어오는 경우 다음과 같은 에러가 발생합니다.[to-be]
인자로
''가 들어오는 경우false로 얼리리턴하여 에러가 발생하지 않도록 수정합니다.PR Checklist