feat: removeLastHangulCharacter 추가 #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 12ce776 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for es-hangul ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
evan-moon
commented
Apr 17, 2024
| @@ -0,0 +1,4 @@ | |||
| export function excludeLastElement(array: string[]): [string[], string] { | |||
There was a problem hiding this comment.
#36 (review) 에서 언급되었던 "라이브러리 내부에서만 사용될 함수"를 위해 _internal.ts 모듈을 생성했습니다.
okinawaa
reviewed
Apr 18, 2024
| import { describe, it, expect } from 'vitest'; | ||
| import { removeLastHangulCharacter } from './removeLastHangulCharacter'; | ||
|
|
||
| describe('removeLastCharacter', () => { |
There was a problem hiding this comment.
마이너합니다! 파일명, 함수명과 describe를 맞춰도 좋을 것 같아서요!
Suggested change
| describe('removeLastCharacter', () => { | |
| describe('removeLastHangulCharacter', () => { |
There was a problem hiding this comment.
a72646e 에서 반영 완료하였습니다 🙇
| * removeLastHangulCharacter('프론트엔드') // 프론트엔ㄷ | ||
| * removeLastHangulCharacter('일요일') // 일요이 | ||
| */ | ||
| export function removeLastHangulCharacter(words: string) { |
There was a problem hiding this comment.
한 단어를 받는 인자라면 복수인 words가 아닌, word로 해도 좋을 것 같아요!
Suggested change
| export function removeLastHangulCharacter(words: string) { | |
| export function removeLastHangulCharacter(word: string) { |
There was a problem hiding this comment.
"안녕하세요 값"처럼 2개 이상의 word도 받을 수 있어서 복수형으로 정의했습니다!
okinawaa
reviewed
Apr 18, 2024
…/es-hangul into feat/removeLastHangulCharacter
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
인자로 받은 한글 문자열에서 마지막 한글 문자 하나를 제거하여 반환하는
removeLastHangulCharacter함수를 추가합니다.이 함수는 개별적으로 사용되기도 하겠지만, #18 에서 제안된
assemble함수의 연음법칙을 구현할 때도 사용됩니다.PR Checklist