fix: Handle spaces in initialConsonants search inputs properly #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 6798078 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for es-hangul ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
@BO-LIKE-CHICKEN ...는 Conflict가 발생했군요 😢 |
BO-LIKE-CHICKEN
force-pushed
the
fix/chosung-search-whitespace-issue
branch
from
64afb00
to
63beabb
Compare
|
@evan-moon 충돌을 해결했습니다! #36 과 충돌이 있었네요 🥲 다시 리뷰해주시면 감사하겠습니다! 다만, #41 이슈에서 @okinawaa 님과 함수의 역할에 대해 논의하기 이전의 PR이므로, 병합 시 문제가 될 가능성이 있습니다. 두 리뷰어의 의견을 모아주시면 좋을 것 같아요. 🙏🏻 해당 이슈에 따른 개선안으로도 PR을 생성할 예정입니다. 감사합니다! |
This was referenced Apr 17, 2024
BO-LIKE-CHICKEN
commented
Apr 19, 2024
src/chosungIncludes.ts
Outdated
| return false; | ||
| } | ||
|
|
||
| const initialConsonantsX = getFirstConsonants(x).replace(/\s/g, ''); | ||
| const initialConsonantsY = getFirstConsonants(y).replace(/\s/g, ''); | ||
| const initialConsonantsY = trimY; |
There was a problem hiding this comment.
위에서 초성으로만 구성되었는지 확인하기 때문에 getFirstConsonants는 필요없습니다.
참고사항
감사합니다! |
okinawaa
reviewed
Apr 19, 2024
Co-authored-by: 박찬혁 <[email protected]>
okinawaa
previously approved these changes
Apr 19, 2024
okinawaa
approved these changes
Apr 19, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
#41 에서 발견한 '공백이 포함된 초성 검색 시 예상치 못한 false 반환 문제'를 공백 포함 입력도 정상적으로 처리하도록 수정했습니다.
PR Checklist