v2 #189
Merged
v2 #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: 4c3e9f9 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #189 +/- ##
==========================================
+ Coverage 97.61% 99.82% +2.21%
==========================================
Files 32 29 -3
Lines 629 583 -46
Branches 146 141 -5
==========================================
- Hits 614 582 -32
+ Misses 14 1 -13
+ Partials 1 0 -1 |
|
changesets/changesets#665 참고하기 좋은 이슈인 것 같아서 남겨요 |
|
squash merge를 반드시 사용하지 않아야 합니다. 리마인드 |
매우 중요해서 리마인드 |
* remove extrachHangul * Create cyan-tigers-sneeze.md --------- Co-authored-by: Jonghyeon Ko <[email protected]>
…angul이라는 글자를 제거합니다 (#184) * dissemble관련 메서드에서 hangul이름을 제거합니다 * 누락된 부분 수정 * resolve conflit * Create late-beers-hang.md * diassembleHangul to diassemble --------- Co-authored-by: Jonghyeon Ko <[email protected]>
* remove acronymize * Create weak-walls-sniff.md --------- Co-authored-by: Jonghyeon Ko <[email protected]>
* getChoseong분리 * write test code * getChoseong import * remove useless import statemenet * remove unused file
…도 함수로 분리합니다. (#193) * canBe series를 별도 함수로 분리합니다 * add change set
* feat: 문자열에서 한글을 추출해주는 extractHangul 함수를 제거합니다 (#185) * remove extrachHangul * Create cyan-tigers-sneeze.md --------- Co-authored-by: Jonghyeon Ko <[email protected]> * feat: disassembleHangul, disassemble, disassembleHangulToGroup 함수에서 hangul이라는 글자를 제거합니다 (#184) * dissemble관련 메서드에서 hangul이름을 제거합니다 * 누락된 부분 수정 * resolve conflit * Create late-beers-hang.md * diassembleHangul to diassemble --------- Co-authored-by: Jonghyeon Ko <[email protected]> * remove hangulIncludes (#188) * feat: 한글의 두음을 반환해주는 acronymizeHangul 함수를 제거합니다. (#180) * remove acronymize * Create weak-walls-sniff.md --------- Co-authored-by: Jonghyeon Ko <[email protected]> * feat: getChoseng을 utils에서 별도 함수로 분리합니다. (#192) * getChoseong분리 * write test code * getChoseong import * remove useless import statemenet * remove unused file * feat: `canBeChoseong`, `canBeJungseong`, `canBeJongseong` 을 utils에서 별도 함수로 분리합니다. (#193) * canBe series를 별도 함수로 분리합니다 * add change set * feat: `hasBatchim` 을 utils에서 별도 함수로 분리합니다. (#195) * hasBatchim * resolve type error * add change set * hasProperty, hasValueInReadOnlyStringList를 internal folder 로 옮깁니다 * resolve test error * move with test code * feat: choseongIncludes함수를 제거합니다. (#197) * remove choseongIncludes Co-authored-by: 서동휘 <[email protected]> * fix: remove 한글 * fix: amountToMoneyCurrency로 함수명 변경 * fix: amountToHangul로 함수명 수정 * fix: conflict * fix: filepath * fix: import 방식 변경 및 CHANGELOG restore * Create kind-birds-provide.md --------- Co-authored-by: 박찬혁 <[email protected]> Co-authored-by: Jonghyeon Ko <[email protected]> Co-authored-by: 서동휘 <[email protected]>
Co-authored-by: 서동휘 <[email protected]> Co-authored-by: minsuKang <[email protected]> Co-authored-by: chaerim kim <[email protected]>
manudeli
reviewed
Aug 5, 2024
Co-authored-by: Jonghyeon Ko <[email protected]>
manudeli
reviewed
Aug 5, 2024
manudeli
reviewed
Aug 5, 2024
manudeli
reviewed
Aug 5, 2024
| ```typescript | ||
| function getChoseong( | ||
| // 초성을 추출 할 한글 문자열 | ||
| word: string |
There was a problem hiding this comment.
반드시 단어가 아니기 때문에 word보다 좋은 변수명이 된다면 좋을 거 같아요
Suggested change
| word: string | |
| xxx: string |
manudeli
reviewed
Aug 5, 2024
| hasBatchim( | ||
| str: string, | ||
| // 홑받침 여부를 확인할지 여부 | ||
| options?: { single?: boolean } |
There was a problem hiding this comment.
아래처럼은 어떨까요? single만 대응되는 것이 한쪽으로 치우친 거 같아서 두 쪽 다 공평히 대응되면 좋을 거 같아요
Suggested change
| options?: { single?: boolean } | |
| options?: { only?: 'single' | 'double' } |
manudeli
reviewed
Aug 5, 2024
| export function assembleHangul(words: string[]) { | ||
| const disassembled = disassembleHangul(words.join('')).split(''); | ||
| return disassembled.reduce(binaryAssembleHangul); | ||
| export function assemble(words: string[]) { |
There was a problem hiding this comment.
assemble이 현재의 disassemble & 현재의 comineCharacter인 거 같아요
현재의 comineCharacter이 오히려 disassemble의 반대의 기능인 거 같아서 assemble로 이름 바꾸는 걸 생각해보면 좋을 거 같아요
- comineCharacter => assemble
- assemble 제거 하면 어떨까해요
Co-authored-by: Jonghyeon Ko <[email protected]>
Co-authored-by: Jonghyeon Ko <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
fix [Bug] 잘못 노출된 불필요 인터페이스 점진적 제거가 필요합니다 #158
fix [Feature]: 정해진 일관된 이름 짓기 규칙에 알맞게 함수명 수정하기 #170
불필요한 함수 제거
함수명 수정
잘못 export된 함수들 수정
PR Checklist
📝 major version update squash merge를 사용하지 않습니다