fix: 패키지가 노출하는 인터페이스를 명확히 하기 위해 index.ts를 named export로 수정합니다 #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: a549ece The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #157 +/- ##
=======================================
Coverage 99.60% 99.60%
=======================================
Files 16 16
Lines 255 255
Branches 56 56
=======================================
Hits 254 254
Misses 1 1 |
manudeli
changed the title
manudeli
commented
Jun 30, 2024
Comment on lines
+1
to
+21
| export { assembleHangul } from './assemble'; | ||
| export { chosungIncludes } from './chosungIncludes'; | ||
| export { combineHangulCharacter, combineVowels, curriedCombineHangulCharacter } from './combineHangulCharacter'; | ||
| export { convertQwertyToHangul, convertQwertyToHangulAlphabet } from './convertQwertyToHangulAlphabet'; | ||
| export { disassembleHangul, disassembleHangulToGroups } from './disassemble'; | ||
| export { disassembleCompleteHangulCharacter } from './disassembleCompleteHangulCharacter'; | ||
| export { hangulIncludes } from './hangulIncludes'; | ||
| export { josa } from './josa'; | ||
| export { removeLastHangulCharacter } from './removeLastHangulCharacter'; | ||
| export { | ||
| canBeChosung, | ||
| canBeJongsung, | ||
| canBeJungsung, | ||
| getChosung, | ||
| hasBatchim, | ||
| hasProperty, | ||
| hasSingleBatchim, | ||
| hasValueInReadOnlyStringList, | ||
| } from './utils'; | ||
| export { extractHangul } from './extractHangul'; | ||
| export { acronymizeHangul } from './acronymizeHangul'; |
There was a problem hiding this comment.
모든 인터페이스가 *로 노출되면 안될 것 같아보여서(테스트용으로 export했을 수 있기 때문에) 현재 이미 노출되고 있는 것은 노출되도록 변경했습니다.
utils와 같은 폴더의 경우 노출되면 안되는 인터페이스 같아서 이슈로도 함께 남겨요. 잘못 노출된 인터페이스는 점진적으로 제거되면 좋을 거 같아요
okinawaa
approved these changes
Jun 30, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
코멘트로 의도를 남겨요
PR Checklist