Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: internal 테스트 코드를 작성합니다 #137

Merged
merged 3 commits into from
Jun 29, 2024

Conversation

po4tion
Copy link
Contributor

@po4tion po4tion commented Jun 26, 2024

Overview

_internal/index.ts에 정의된 기능들에 대해 테스트 코드를 작성합니다.

테스트 작성전
image

테스트 작성후
image

PR Checklist

  • I read and included theses actions below
  1. I have read the Contributing Guide
  2. I have written documents and tests, if needed.

Copy link

changeset-bot bot commented Jun 26, 2024

⚠️ No Changeset found

Latest commit: 7526118

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Jun 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
es-hangul ❌ Failed (Inspect) Jun 29, 2024 0:03am

@codecov-commenter
Copy link

codecov-commenter commented Jun 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.56%. Comparing base (db94449) to head (32b040d).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #137   +/-   ##
=======================================
  Coverage   99.56%   99.56%           
=======================================
  Files          14       14           
  Lines         230      230           
  Branches       51       51           
=======================================
  Hits          229      229           
  Misses          1        1           

Copy link
Member

@okinawaa okinawaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

엣지케이스까지 고려해가며, 테스트 코드 꼼꼼하게 작성해주셔서 감사해요!

@okinawaa okinawaa merged commit b0b2541 into toss:main Jun 29, 2024
2 of 3 checks passed
seungrodotlee pushed a commit to seungrodotlee/es-hangul that referenced this pull request Jul 6, 2024
* test: internal 테스트 코드를 작성합니다

* test: vitest에서 제공해주는 toThrowError로 변경

---------

Co-authored-by: 박찬혁 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants