Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Adopters 컴포넌트를 수정합니다 #117

Merged
merged 2 commits into from
Jun 7, 2024

Conversation

po4tion
Copy link
Contributor

@po4tion po4tion commented Jun 6, 2024

Overview

  1. Adopters 컴포넌트의 div 태그의 스타일 작성법을 다른 컴포넌트들과 동일하게 tailwindcss로 변경하였습니다
  2. Image 태그에 올바르지 않게 적용된 props를 수정하였습니다.

Image 태그에 DOM element가 지원하지 않는 darkSrc 속성이 적용됨.

image
image

eslint rule 중 하나인 jsx-a11y/alt-text로 인해 alt prop을 컴포넌트에 명시해야 함.

alt 값을 굳이 명시하고 싶지 않다면 eslint rule 설정을 변경하는 것도 선택지 중 하나인 것 같습니다.

image

PR Checklist

  • I read and included theses actions below
  1. I have read the Contributing Guide
  2. I have written documents and tests, if needed.

Copy link

changeset-bot bot commented Jun 6, 2024

⚠️ No Changeset found

Latest commit: bc171ad

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Jun 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
es-hangul ❌ Failed (Inspect) Jun 6, 2024 3:59pm

@po4tion po4tion changed the title fix: Adopters 컴포넌트를 개선합니다 fix: Adopters 컴포넌트를 수정합니다 Jun 6, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (dae9deb) to head (bc171ad).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #117   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           13        13           
  Lines          206       206           
  Branches        46        46           
=========================================
  Hits           206       206           

Copy link
Member

@okinawaa okinawaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

감사합니다 ☺️

@okinawaa okinawaa merged commit bf863d9 into toss:main Jun 7, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants