Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: removeLastHangulCharacter 호환성 개선 - 문자열의 마지막 글자 가져오는 로직 수정 #113

Merged
merged 5 commits into from
Jun 3, 2024

Conversation

jungwoo3490
Copy link
Contributor

Overview

#83 과 같은 이유로 호환성 개선을 위해 removeLastHangulCharacter에서 문자열의 마지막 글자를 가져오는 로직을 수정하였습니다.

PR Checklist

  • I read and included theses actions below
  1. I have read the Contributing Guide
  2. I have written documents and tests, if needed.

Copy link

vercel bot commented Jun 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
es-hangul ❌ Failed (Inspect) Jun 1, 2024 6:21pm

Copy link

changeset-bot bot commented Jun 1, 2024

⚠️ No Changeset found

Latest commit: f235a18

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.51%. Comparing base (5379e66) to head (f235a18).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #113   +/-   ##
=======================================
  Coverage   99.51%   99.51%           
=======================================
  Files          13       13           
  Lines         206      206           
  Branches       46       46           
=======================================
  Hits          205      205           
  Misses          1        1           

Copy link
Member

@evan-moon evan-moon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 기여 감사합니다 @jungwoo3490 님!

@evan-moon evan-moon merged commit 0c71f6f into toss:main Jun 3, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants