Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: 1kb 문구 제거 #110

Merged
merged 1 commit into from
Jun 1, 2024
Merged

docs: 1kb 문구 제거 #110

merged 1 commit into from
Jun 1, 2024

Conversation

manudeli
Copy link
Member

Overview

image

더 이상 gzip사이즈가 1kb가 아니어서 문구를 제거합니다. es-hangul's bundle size
제거해도 아래 자동으로 트래킹되는 뱃지가 있어서 번들이 작다는 메시지는 충분히 전달될 것으로 기대하고 있습니다

PR Checklist

  • I read and included theses actions below
  1. I have read the Contributing Guide
  2. I have written documents and tests, if needed.

Copy link

vercel bot commented May 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
es-hangul ❌ Failed (Inspect) May 30, 2024 11:52am

Copy link

changeset-bot bot commented May 30, 2024

⚠️ No Changeset found

Latest commit: 846cb4b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@manudeli manudeli self-assigned this May 30, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.51%. Comparing base (0cd45e4) to head (846cb4b).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #110   +/-   ##
=======================================
  Coverage   99.51%   99.51%           
=======================================
  Files          13       13           
  Lines         206      206           
  Branches       46       46           
=======================================
  Hits          205      205           
  Misses          1        1           

Copy link
Member

@okinawaa okinawaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.3.0 버전부터 gzip크기가 커졌군요! 한번 작게 제공할 수 있는지 살펴볼게요~

@okinawaa okinawaa merged commit 5379e66 into main Jun 1, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants