Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(broken-link-checker): 망가진 링크를 자동으로 잡도록 워크플로우 스케줄링 #109

Merged
merged 2 commits into from
Jun 1, 2024

Conversation

manudeli
Copy link
Member

Overview

이 변경이 추가되면 매일 문서의 모든 link를 자동으로 체크하고 문제가 없는 지 알려줍니다. 또한 수동으로 workflow_dispatch를 사용해 수동으로 작동시킬 수도 있습니다

현재도 이미 broken link가 있습니다. 이러한 오류를 조기에 발견하고 해결할 수 있게 됩니다
image

https://es-hangul.slash.page/docs/api/chosungIncludes 이 페이지에 들어가서 수정하기 버튼을 누르면 잘못된 링크로 보내지는데 이것을 자동으로 잡을 수 있습니다 해결은 다른 PR에서 수정되면 좋겠습니다

PR Checklist

  • I read and included theses actions below
  1. I have read the Contributing Guide
  2. I have written documents and tests, if needed.

@manudeli manudeli self-assigned this May 30, 2024
Copy link

changeset-bot bot commented May 30, 2024

⚠️ No Changeset found

Latest commit: b8edb17

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented May 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
es-hangul ❌ Failed (Inspect) Jun 1, 2024 0:18am

@manudeli manudeli changed the title ci(broken-link-checker): add scheduler to check broken links automatically ci(broken-link-checker): 망가진 링크를 자동으로 잡도록 워크플로우 스케줄링 May 30, 2024
@codecov-commenter
Copy link

codecov-commenter commented May 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.51%. Comparing base (4d479b0) to head (b8edb17).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #109   +/-   ##
=======================================
  Coverage   99.51%   99.51%           
=======================================
  Files          13       13           
  Lines         206      206           
  Branches       46       46           
=======================================
  Hits          205      205           
  Misses          1        1           

@juno7803
Copy link
Member

juno7803 commented Jun 1, 2024

본문에 언급해주신 https://es-hangul.slash.page/docs/api/chosungIncludes 문서는 #102 에서 머지된 후 제대로 배포되지 않아 발생하는 문제 같습니다! (link-checker 덕분에 발견할 수 있었군요 👍) @okinawaa 혹시 한번 확인 부탁드려도 될까요?!

Copy link
Member

@okinawaa okinawaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

너무 좋은 기능이네요 👍

@okinawaa okinawaa merged commit bbb150a into main Jun 1, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants