Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: README 파일에 있는 chosungIncludes 예시의 결과 추가 #105

Merged
merged 3 commits into from
May 26, 2024

Conversation

Collection50
Copy link
Contributor

Overview

AS-IS

import { chosungIncludes } from 'es-hangul';

const searchWord = '라면';
const userInput = 'ㄹㅁ';

const result = chosungIncludes(searchWord, userInput);

TO-BE

import { chosungIncludes } from 'es-hangul';

const searchWord = '라면';
const userInput = 'ㄹㅁ';

const result = chosungIncludes(searchWord, userInput); // true

PR Checklist

  • I read and included theses actions below
  1. I have read the Contributing Guide
  2. I have written documents and tests, if needed.

Copy link

changeset-bot bot commented May 26, 2024

⚠️ No Changeset found

Latest commit: 6ec9827

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented May 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
es-hangul ❌ Failed (Inspect) May 26, 2024 5:44am

@okinawaa
Copy link
Member

감사해요! 영어용 리드미에도 추가될 수 있을까요~?

@Collection50
Copy link
Contributor Author

감사해요! 영어용 리드미에도 추가될 수 있을까요~?

바로 작업해두겠습니다 ! 👍

Copy link
Member

@okinawaa okinawaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

감사합니다!!

@okinawaa okinawaa merged commit 0cd45e4 into toss:main May 26, 2024
1 of 2 checks passed
@Collection50
Copy link
Contributor Author

감사합니다!!

항상 풍성하고 활발한 개발 생태계가 될 수 있도록 힘써주셔서 감사합니다 ☺️

외람되지만 toss/slash를 더 선언적으로 사용하기 위한

  1. OutsideClick HOC
  2. 더 선언적인 ErrorBoundary fallback

PR을 작성했습니다 !
여유로우실 때 리뷰해주시면 감사하겠습니다 ! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants