Skip to content

Commit

Permalink
leds: trigger: Stop exporting trigger_list
Browse files Browse the repository at this point in the history
Commit 682e985 ("leds: trigger: panic: Simplify
led_trigger_set_panic") removed the last external user of variable
trigger_list. So stop exporting it. If in future a need should arise
again to access this variable, I think we better add some accessor
instead of exporting the variable directly.

Signed-off-by: Heiner Kallweit <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Lee Jones <[email protected]>
  • Loading branch information
hkallweit authored and lag-linaro committed Mar 7, 2024
1 parent 09e3f32 commit e838a5a
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 2 deletions.
2 changes: 1 addition & 1 deletion drivers/leds/led-triggers.c
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
* Nests outside led_cdev->trigger_lock
*/
static DECLARE_RWSEM(triggers_list_lock);
LIST_HEAD(trigger_list);
static LIST_HEAD(trigger_list);

/* Used by LED Class */

Expand Down
1 change: 0 additions & 1 deletion drivers/leds/leds.h
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@ ssize_t led_trigger_write(struct file *filp, struct kobject *kobj,

extern struct rw_semaphore leds_list_lock;
extern struct list_head leds_list;
extern struct list_head trigger_list;
extern const char * const led_colors[LED_COLOR_ID_MAX];

#endif /* __LEDS_H_INCLUDED */

0 comments on commit e838a5a

Please sign in to comment.