kunit: tool: Do not colorize output when redirected

Filling log files with color codes makes diffs and other comparisons difficult. Only emit vt100 codes when the stdout is a TTY. Cc: Brendan Higgins <[email protected]> Cc: [email protected] Cc: [email protected] Signed-off-by: Kees Cook <[email protected]> Reviewed-by: David Gow <[email protected]> Reviewed-by: Brendan Higgins <[email protected]> Signed-off-by: Shuah Khan <[email protected]>
torvalds · Apr 4, 2022 · d34f82d · d34f82d
1 parent 885210d
commit d34f82d
Showing 1 changed file with 7 additions and 0 deletions.
diff --git a/tools/testing/kunit/kunit_parser.py b/tools/testing/kunit/kunit_parser.py
@@ -11,6 +11,7 @@
 
 from __future__ import annotations
 import re
+import sys
 
 import datetime
 from enum import Enum, auto
@@ -503,14 +504,20 @@ def parse_crash_in_log(test: Test) -> bool:
 
 def red(text: str) -> str:
  """Returns inputted string with red color code."""
+ if not sys.stdout.isatty():
+ return text
  return '\033[1;31m' + text + RESET
 
 def yellow(text: str) -> str:
  """Returns inputted string with yellow color code."""
+ if not sys.stdout.isatty():
+ return text
  return '\033[1;33m' + text + RESET
 
 def green(text: str) -> str:
  """Returns inputted string with green color code."""
+ if not sys.stdout.isatty():
+ return text
  return '\033[1;32m' + text + RESET
 
 ANSI_LEN = len(red(''))