KVM: arm64: vgic-its: Walk LPI xarray in vgic_its_invall()

The new LPI xarray makes it possible to walk the VM's LPIs without holding a lock, meaning that vgic_copy_lpi_list() is no longer necessary. Prepare for the deletion by walking the LPI xarray directly in vgic_its_invall(). Signed-off-by: Oliver Upton <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Marc Zyngier <[email protected]>
torvalds · Apr 25, 2024 · c64115c · c64115c
1 parent 720f73b
commit c64115c
Showing 1 changed file with 6 additions and 10 deletions.
diff --git a/arch/arm64/kvm/vgic/vgic-its.c b/arch/arm64/kvm/vgic/vgic-its.c
@@ -1365,23 +1365,19 @@ static int vgic_its_cmd_handle_inv(struct kvm *kvm, struct vgic_its *its,
 int vgic_its_invall(struct kvm_vcpu *vcpu)
 {
  struct kvm *kvm = vcpu->kvm;
- int irq_count, i = 0;
- u32 *intids;
-
- irq_count = vgic_copy_lpi_list(kvm, vcpu, &intids);
- if (irq_count < 0)
- return irq_count;
+ struct vgic_dist *dist = &kvm->arch.vgic;
+ struct vgic_irq *irq;
+ unsigned long intid;
 
- for (i = 0; i < irq_count; i++) {
- struct vgic_irq *irq = vgic_get_irq(kvm, NULL, intids[i]);
+ xa_for_each(&dist->lpi_xa, intid, irq) {
+ irq = vgic_get_irq(kvm, NULL, intid);
  if (!irq)
  continue;
+
  update_lpi_config(kvm, irq, vcpu, false);
  vgic_put_irq(kvm, irq);
  }
 
- kfree(intids);
-
  if (vcpu->arch.vgic_cpu.vgic_v3.its_vpe.its_vm)
  its_invall_vpe(&vcpu->arch.vgic_cpu.vgic_v3.its_vpe);