floppy: make local variable non-static

There's no reason for temparea to be static, since it's only used for temporary sprintf output. It's not immediately obvious that the output will always fit (in the worst case, the output including '\0' is exactly 32 bytes), so save a future reader from worrying about that. Signed-off-by: Rasmus Villemoes <[email protected]> Signed-off-by: Jiri Kosina <[email protected]>
torvalds · Dec 8, 2015 · bcf4299 · bcf4299
1 parent 8e39111
commit bcf4299
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/drivers/block/floppy.c b/drivers/block/floppy.c
@@ -3585,7 +3585,7 @@ static void __init config_types(void)
  unsigned int type = UDP->cmos;
  struct floppy_drive_params *params;
  const char *name = NULL;
- static char temparea[32];
+ char temparea[32];
 
  if (type < ARRAY_SIZE(default_drive_params)) {
  params = &default_drive_params[type].params;
@@ -3596,7 +3596,8 @@ static void __init config_types(void)
  allowed_drive_mask &= ~(1 << drive);
  } else {
  params = &default_drive_params[0].params;
- sprintf(temparea, "unknown type %d (usb?)", type);
+ snprintf(temparea, sizeof(temparea),
+ "unknown type %d (usb?)", type);
  name = temparea;
  }
  if (name) {