Skip to content

Commit

Permalink
lib: reduce the use of module.h wherever possible
Browse files Browse the repository at this point in the history
For files only using THIS_MODULE and/or EXPORT_SYMBOL, map
them onto including export.h -- or if the file isn't even
using those, then just delete the include.  Fix up any implicit
include dependencies that were being masked by module.h along
the way.

Signed-off-by: Paul Gortmaker <[email protected]>
  • Loading branch information
paulgortmaker committed Mar 7, 2012
1 parent 630d9c4 commit 8bc3bcc
Show file tree
Hide file tree
Showing 63 changed files with 74 additions and 63 deletions.
2 changes: 1 addition & 1 deletion lib/argv_split.c
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
#include <linux/ctype.h>
#include <linux/string.h>
#include <linux/slab.h>
#include <linux/module.h>
#include <linux/export.h>

static const char *skip_arg(const char *cp)
{
Expand Down
2 changes: 1 addition & 1 deletion lib/atomic64.c
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
#include <linux/cache.h>
#include <linux/spinlock.h>
#include <linux/init.h>
#include <linux/module.h>
#include <linux/export.h>
#include <linux/atomic.h>

/*
Expand Down
3 changes: 2 additions & 1 deletion lib/average.c
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,9 @@
* Version 2. See the file COPYING for more details.
*/

#include <linux/module.h>
#include <linux/export.h>
#include <linux/average.h>
#include <linux/kernel.h>
#include <linux/bug.h>
#include <linux/log2.h>

Expand Down
2 changes: 1 addition & 1 deletion lib/bcd.c
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#include <linux/bcd.h>
#include <linux/module.h>
#include <linux/export.h>

unsigned bcd2bin(unsigned char val)
{
Expand Down
3 changes: 2 additions & 1 deletion lib/bitmap.c
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,8 @@
* This source code is licensed under the GNU General Public License,
* Version 2. See the file COPYING for more details.
*/
#include <linux/module.h>
#include <linux/export.h>
#include <linux/thread_info.h>
#include <linux/ctype.h>
#include <linux/errno.h>
#include <linux/bitmap.h>
Expand Down
2 changes: 1 addition & 1 deletion lib/bsearch.c
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
* published by the Free Software Foundation; version 2.
*/

#include <linux/module.h>
#include <linux/export.h>
#include <linux/bsearch.h>

/*
Expand Down
2 changes: 1 addition & 1 deletion lib/check_signature.c
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#include <linux/io.h>
#include <linux/module.h>
#include <linux/export.h>

/**
* check_signature - find BIOS signatures
Expand Down
2 changes: 1 addition & 1 deletion lib/checksum.c
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
/* Revised by Kenneth Albanowski for m68knommu. Basic problem: unaligned access
kills, so most of the assembly has to go. */

#include <linux/module.h>
#include <linux/export.h>
#include <net/checksum.h>

#include <asm/byteorder.h>
Expand Down
2 changes: 1 addition & 1 deletion lib/cmdline.c
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
*
*/

#include <linux/module.h>
#include <linux/export.h>
#include <linux/kernel.h>
#include <linux/string.h>

Expand Down
2 changes: 1 addition & 1 deletion lib/cpu_rmap.c
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
#ifdef CONFIG_GENERIC_HARDIRQS
#include <linux/interrupt.h>
#endif
#include <linux/module.h>
#include <linux/export.h>

/*
* These functions maintain a mapping from CPUs to some ordered set of
Expand Down
2 changes: 1 addition & 1 deletion lib/cpumask.c
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
#include <linux/kernel.h>
#include <linux/bitops.h>
#include <linux/cpumask.h>
#include <linux/module.h>
#include <linux/export.h>
#include <linux/bootmem.h>

int __first_cpu(const cpumask_t *srcp)
Expand Down
3 changes: 2 additions & 1 deletion lib/ctype.c
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,8 @@
*/

#include <linux/ctype.h>
#include <linux/module.h>
#include <linux/compiler.h>
#include <linux/export.h>

const unsigned char _ctype[] = {
_C,_C,_C,_C,_C,_C,_C,_C, /* 0-7 */
Expand Down
2 changes: 1 addition & 1 deletion lib/debug_locks.c
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
*/
#include <linux/rwsem.h>
#include <linux/mutex.h>
#include <linux/module.h>
#include <linux/export.h>
#include <linux/spinlock.h>
#include <linux/debug_locks.h>

Expand Down
2 changes: 1 addition & 1 deletion lib/dec_and_lock.c
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#include <linux/module.h>
#include <linux/export.h>
#include <linux/spinlock.h>
#include <linux/atomic.h>

Expand Down
2 changes: 1 addition & 1 deletion lib/devres.c
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
#include <linux/pci.h>
#include <linux/io.h>
#include <linux/gfp.h>
#include <linux/module.h>
#include <linux/export.h>

void devm_ioremap_release(struct device *dev, void *res)
{
Expand Down
3 changes: 2 additions & 1 deletion lib/div64.c
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,8 @@
* assembly versions such as arch/ppc/lib/div64.S and arch/sh/lib/div64.S.
*/

#include <linux/module.h>
#include <linux/export.h>
#include <linux/kernel.h>
#include <linux/math64.h>

/* Not needed on 64bit architectures */
Expand Down
2 changes: 1 addition & 1 deletion lib/dump_stack.c
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
*/

#include <linux/kernel.h>
#include <linux/module.h>
#include <linux/export.h>

void dump_stack(void)
{
Expand Down
2 changes: 1 addition & 1 deletion lib/fault-inject.c
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
#include <linux/stat.h>
#include <linux/types.h>
#include <linux/fs.h>
#include <linux/module.h>
#include <linux/export.h>
#include <linux/interrupt.h>
#include <linux/stacktrace.h>
#include <linux/fault-inject.h>
Expand Down
2 changes: 1 addition & 1 deletion lib/find_last_bit.c
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
*/

#include <linux/bitops.h>
#include <linux/module.h>
#include <linux/export.h>
#include <asm/types.h>
#include <asm/byteorder.h>

Expand Down
2 changes: 1 addition & 1 deletion lib/find_next_bit.c
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
*/

#include <linux/bitops.h>
#include <linux/module.h>
#include <linux/export.h>
#include <asm/types.h>
#include <asm/byteorder.h>

Expand Down
2 changes: 1 addition & 1 deletion lib/flex_array.c
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
#include <linux/flex_array.h>
#include <linux/slab.h>
#include <linux/stddef.h>
#include <linux/module.h>
#include <linux/export.h>
#include <linux/reciprocal_div.h>

struct flex_array_part {
Expand Down
2 changes: 1 addition & 1 deletion lib/gcd.c
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#include <linux/kernel.h>
#include <linux/gcd.h>
#include <linux/module.h>
#include <linux/export.h>

/* Greatest common divisor */
unsigned long gcd(unsigned long a, unsigned long b)
Expand Down
2 changes: 1 addition & 1 deletion lib/genalloc.c
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
*/

#include <linux/slab.h>
#include <linux/module.h>
#include <linux/export.h>
#include <linux/bitmap.h>
#include <linux/rculist.h>
#include <linux/interrupt.h>
Expand Down
2 changes: 1 addition & 1 deletion lib/halfmd4.c
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#include <linux/kernel.h>
#include <linux/module.h>
#include <linux/export.h>
#include <linux/cryptohash.h>

/* F, G and H are basic MD4 functions: selection, majority, parity */
Expand Down
2 changes: 1 addition & 1 deletion lib/hexdump.c
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
#include <linux/types.h>
#include <linux/ctype.h>
#include <linux/kernel.h>
#include <linux/module.h>
#include <linux/export.h>

const char hex_asc[] = "0123456789abcdef";
EXPORT_SYMBOL(hex_asc);
Expand Down
2 changes: 1 addition & 1 deletion lib/hweight.c
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#include <linux/module.h>
#include <linux/export.h>
#include <linux/bitops.h>
#include <asm/types.h>

Expand Down
2 changes: 1 addition & 1 deletion lib/idr.c
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
#ifndef TEST // to test in user space...
#include <linux/slab.h>
#include <linux/init.h>
#include <linux/module.h>
#include <linux/export.h>
#endif
#include <linux/err.h>
#include <linux/string.h>
Expand Down
2 changes: 1 addition & 1 deletion lib/int_sqrt.c
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@

#include <linux/kernel.h>
#include <linux/module.h>
#include <linux/export.h>

/**
* int_sqrt - rough approximation to sqrt
Expand Down
2 changes: 1 addition & 1 deletion lib/iomap.c
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
#include <linux/pci.h>
#include <linux/io.h>

#include <linux/module.h>
#include <linux/export.h>

/*
* Read/write from/to an (offsettable) iomem cookie. It might be a PIO
Expand Down
2 changes: 1 addition & 1 deletion lib/iomap_copy.c
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA.
*/

#include <linux/module.h>
#include <linux/export.h>
#include <linux/io.h>

/**
Expand Down
2 changes: 1 addition & 1 deletion lib/iommu-helper.c
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
* IOMMU helper functions for the free area management
*/

#include <linux/module.h>
#include <linux/export.h>
#include <linux/bitmap.h>

int iommu_is_span_boundary(unsigned int index, unsigned int nr,
Expand Down
2 changes: 1 addition & 1 deletion lib/ioremap.c
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
#include <linux/mm.h>
#include <linux/sched.h>
#include <linux/io.h>
#include <linux/module.h>
#include <linux/export.h>
#include <asm/cacheflush.h>
#include <asm/pgtable.h>

Expand Down
3 changes: 2 additions & 1 deletion lib/irq_regs.c
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,8 @@
* as published by the Free Software Foundation; either version
* 2 of the License, or (at your option) any later version.
*/
#include <linux/module.h>
#include <linux/export.h>
#include <linux/percpu.h>
#include <asm/irq_regs.h>

#ifndef ARCH_HAS_OWN_IRQ_REGS
Expand Down
2 changes: 1 addition & 1 deletion lib/kasprintf.c
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
*/

#include <stdarg.h>
#include <linux/module.h>
#include <linux/export.h>
#include <linux/slab.h>
#include <linux/types.h>
#include <linux/string.h>
Expand Down
2 changes: 1 addition & 1 deletion lib/klist.c
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
*/

#include <linux/klist.h>
#include <linux/module.h>
#include <linux/export.h>
#include <linux/sched.h>

/*
Expand Down
2 changes: 1 addition & 1 deletion lib/kobject.c
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@

#include <linux/kobject.h>
#include <linux/string.h>
#include <linux/module.h>
#include <linux/export.h>
#include <linux/stat.h>
#include <linux/slab.h>

Expand Down
3 changes: 2 additions & 1 deletion lib/kobject_uevent.c
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,8 @@
#include <linux/spinlock.h>
#include <linux/string.h>
#include <linux/kobject.h>
#include <linux/module.h>
#include <linux/export.h>
#include <linux/kmod.h>
#include <linux/slab.h>
#include <linux/user_namespace.h>
#include <linux/socket.h>
Expand Down
2 changes: 1 addition & 1 deletion lib/kstrtox.c
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
#include <linux/errno.h>
#include <linux/kernel.h>
#include <linux/math64.h>
#include <linux/module.h>
#include <linux/export.h>
#include <linux/types.h>
#include <asm/uaccess.h>
#include "kstrtox.h"
Expand Down
2 changes: 1 addition & 1 deletion lib/lcm.c
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#include <linux/kernel.h>
#include <linux/gcd.h>
#include <linux/module.h>
#include <linux/export.h>
#include <linux/lcm.h>

/* Lowest common multiple */
Expand Down
3 changes: 2 additions & 1 deletion lib/list_debug.c
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,9 @@
* DEBUG_LIST.
*/

#include <linux/module.h>
#include <linux/export.h>
#include <linux/list.h>
#include <linux/kernel.h>

/*
* Insert a new entry between two known consecutive entries.
Expand Down
2 changes: 1 addition & 1 deletion lib/llist.c
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
* Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
*/
#include <linux/kernel.h>
#include <linux/module.h>
#include <linux/export.h>
#include <linux/interrupt.h>
#include <linux/llist.h>

Expand Down
1 change: 0 additions & 1 deletion lib/locking-selftest.c
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@
#include <linux/mutex.h>
#include <linux/sched.h>
#include <linux/delay.h>
#include <linux/module.h>
#include <linux/lockdep.h>
#include <linux/spinlock.h>
#include <linux/kallsyms.h>
Expand Down
2 changes: 1 addition & 1 deletion lib/md5.c
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#include <linux/kernel.h>
#include <linux/module.h>
#include <linux/export.h>
#include <linux/cryptohash.h>

#define F1(x, y, z) (z ^ (x & (y ^ z)))
Expand Down
2 changes: 1 addition & 1 deletion lib/nlattr.c
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
* Alexey Kuznetsov <[email protected]>
*/

#include <linux/module.h>
#include <linux/export.h>
#include <linux/kernel.h>
#include <linux/errno.h>
#include <linux/jiffies.h>
Expand Down
3 changes: 2 additions & 1 deletion lib/parser.c
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,8 @@
*/

#include <linux/ctype.h>
#include <linux/module.h>
#include <linux/types.h>
#include <linux/export.h>
#include <linux/parser.h>
#include <linux/slab.h>
#include <linux/string.h>
Expand Down
Loading

0 comments on commit 8bc3bcc

Please sign in to comment.