Skip to content

Commit

Permalink
wifi: ath11k: allow system suspend to survive ath11k
Browse files Browse the repository at this point in the history
When ath11k runs into internal errors upon suspend,
it returns an error code to pci_pm_suspend, which
aborts the entire system suspend.

The driver should not abort system suspend, but should
keep its internal errors to itself, and allow the system
to suspend.  Otherwise, a user can suspend a laptop
by closing the lid and sealing it into a case, assuming
that is will suspend, rather than heating up and draining
the battery when in transit.

In practice, the ath11k device seems to have plenty of transient
errors, and subsequent suspend cycles after this failure
often succeed.

https://bugzilla.kernel.org/show_bug.cgi?id=216968

Fixes: d1b0c33 ("ath11k: implement suspend for QCA6390 PCI devices")

Signed-off-by: Len Brown <[email protected]>
Cc: [email protected]
Signed-off-by: Kalle Valo <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
  • Loading branch information
lenb authored and Kalle Valo committed Feb 22, 2023
1 parent 5b7c4ca commit 7c15430
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/net/wireless/ath/ath11k/pci.c
Original file line number Diff line number Diff line change
Expand Up @@ -981,7 +981,7 @@ static __maybe_unused int ath11k_pci_pm_suspend(struct device *dev)
if (ret)
ath11k_warn(ab, "failed to suspend core: %d\n", ret);

return ret;
return 0;
}

static __maybe_unused int ath11k_pci_pm_resume(struct device *dev)
Expand Down

0 comments on commit 7c15430

Please sign in to comment.