Skip to content

Commit

Permalink
kunit: fix debugfs code to use enum kunit_status, not bool
Browse files Browse the repository at this point in the history
Commit 6d2426b ("kunit: Support skipped tests") switched to using
`enum kunit_status` to track the result of running a test/suite since we
now have more than just pass/fail.

This callsite wasn't updated, silently converting to enum to a bool and
then back.

Fixes: 6d2426b ("kunit: Support skipped tests")
Signed-off-by: Daniel Latypov <[email protected]>
Reviewed-by: Brendan Higgins <[email protected]>
Signed-off-by: Shuah Khan <[email protected]>
  • Loading branch information
dlatypov authored and shuahkh committed May 2, 2022
1 parent 3b91f82 commit 38289a2
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion lib/kunit/debugfs.c
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ static void debugfs_print_result(struct seq_file *seq,
static int debugfs_print_results(struct seq_file *seq, void *v)
{
struct kunit_suite *suite = (struct kunit_suite *)seq->private;
bool success = kunit_suite_has_succeeded(suite);
enum kunit_status success = kunit_suite_has_succeeded(suite);
struct kunit_case *test_case;

if (!suite || !suite->log)
Expand Down

0 comments on commit 38289a2

Please sign in to comment.