Skip to content

Commit

Permalink
firewire: net: really fix maximum possible MTU
Browse files Browse the repository at this point in the history
The maximum unicast datagram size /without/ link fragmentation is
4096 - 4 = 4092 (max IEEE 1394 async payload size at >= S800 bus speed,
minus unfragmented encapssulation header).  Max broadcast datagram size
without fragmentation is 8 bytes less than that (due to GASP header).

The maximum datagram size /with/ link fragmentation is 0xfff = 4095
for unicast and broadcast.  This is because the RFC 2734 fragment
encapsulation header field for datagram size is only 12 bits wide.

Fixes: 5d48f00('firewire: net: fix maximum possible MTU')
Signed-off-by: Stefan Richter <[email protected]>
Signed-off-by: David S. Miller <[email protected]>
  • Loading branch information
Stefan Richter authored and davem330 committed Oct 30, 2016
1 parent 0e82c76 commit 357f4aa
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/firewire/net.c
Original file line number Diff line number Diff line change
Expand Up @@ -1465,7 +1465,7 @@ static int fwnet_probe(struct fw_unit *unit,

net->mtu = 1500U;
net->min_mtu = ETH_MIN_MTU;
net->max_mtu = ETH_MAX_MTU;
net->max_mtu = 0xfff;

/* Set our hardware address while we're at it */
ha = (union fwnet_hwaddr *)net->dev_addr;
Expand Down

0 comments on commit 357f4aa

Please sign in to comment.