bpf, devmap: Remove unnecessary if check in for loop

The iterator variable dst cannot be NULL and the if check can be removed. Remove it and fix the following Coccinelle/coccicheck warning reported by itnull.cocci: ERROR: iterator variable bound on line 762 cannot be NULL Signed-off-by: Thorsten Blum <[email protected]> Signed-off-by: Daniel Borkmann <[email protected]> Reviewed-by: Toke Høiland-Jørgensen <[email protected]> Acked-by: Jiri Olsa <[email protected]> Link: https://lore.kernel.org/bpf/[email protected]
torvalds · Jun 3, 2024 · 2317dc2 · 2317dc2
1 parent 7d0b395
commit 2317dc2
Showing 1 changed file with 0 additions and 3 deletions.
diff --git a/kernel/bpf/devmap.c b/kernel/bpf/devmap.c
@@ -760,9 +760,6 @@ int dev_map_redirect_multi(struct net_device *dev, struct sk_buff *skb,
  for (i = 0; i < dtab->n_buckets; i++) {
  head = dev_map_index_hash(dtab, i);
  hlist_for_each_entry_safe(dst, next, head, index_hlist) {
- if (!dst)
- continue;
-
  if (is_ifindex_excluded(excluded_devices, num_excluded,
  dst->dev->ifindex))
  continue;