Skip to content

Commit

Permalink
nvme-pci: drop redundant pci_enable_pcie_error_reporting()
Browse files Browse the repository at this point in the history
pci_enable_pcie_error_reporting() enables the device to send ERR_*
Messages.  Since f26e58b ("PCI/AER: Enable error reporting when AER is
native"), the PCI core does this for all devices during enumeration, so the
driver doesn't need to do it itself.

Remove the redundant pci_enable_pcie_error_reporting() call from the
driver.  Also remove the corresponding pci_disable_pcie_error_reporting()
from the driver .remove() path.

Note that this only controls ERR_* Messages from the device.  An ERR_*
Message may cause the Root Port to generate an interrupt, depending on the
AER Root Error Command register managed by the AER service driver.

Signed-off-by: Bjorn Helgaas <[email protected]>
Reviewed-by: Chaitanya Kulkarni <[email protected]>
Signed-off-by: Christoph Hellwig <[email protected]>
  • Loading branch information
bjorn-helgaas authored and Christoph Hellwig committed Apr 13, 2023
1 parent d8898ee commit 1ad11ea
Showing 1 changed file with 1 addition and 5 deletions.
6 changes: 1 addition & 5 deletions drivers/nvme/host/pci.c
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
*/

#include <linux/acpi.h>
#include <linux/aer.h>
#include <linux/async.h>
#include <linux/blkdev.h>
#include <linux/blk-mq.h>
Expand Down Expand Up @@ -2535,7 +2534,6 @@ static int nvme_pci_enable(struct nvme_dev *dev)

nvme_map_cmb(dev);

pci_enable_pcie_error_reporting(pdev);
pci_save_state(pdev);

result = nvme_pci_configure_admin_queue(dev);
Expand Down Expand Up @@ -2600,10 +2598,8 @@ static void nvme_dev_disable(struct nvme_dev *dev, bool shutdown)
nvme_suspend_io_queues(dev);
nvme_suspend_queue(dev, 0);
pci_free_irq_vectors(pdev);
if (pci_is_enabled(pdev)) {
pci_disable_pcie_error_reporting(pdev);
if (pci_is_enabled(pdev))
pci_disable_device(pdev);
}
nvme_reap_pending_cqes(dev);

nvme_cancel_tagset(&dev->ctrl);
Expand Down

0 comments on commit 1ad11ea

Please sign in to comment.