cifs: fix DFS mount with cifsacl/modefromsid

RHBZ: 1871246 If during cifs_lookup()/get_inode_info() we encounter a DFS link and we use the cifsacl or modefromsid mount options we must suppress any -EREMOTE errors that triggers or else we will not be able to follow the DFS link and automount the target. This fixes an issue with modefromsid/cifsacl where these mountoptions would break DFS and we would no longer be able to access the share. Signed-off-by: Ronnie Sahlberg <[email protected]> Reviewed-by: Paulo Alcantara (SUSE) <[email protected]> Signed-off-by: Steve French <[email protected]>
torvalds · Sep 7, 2020 · 01ec372 · 01ec372
1 parent f4d51df
commit 01ec372
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/fs/cifs/inode.c b/fs/cifs/inode.c
@@ -1017,6 +1017,8 @@ cifs_get_inode_info(struct inode **inode,
  if (cifs_sb->mnt_cifs_flags & CIFS_MOUNT_MODE_FROM_SID) {
  rc = cifs_acl_to_fattr(cifs_sb, &fattr, *inode, true,
  full_path, fid);
+ if (rc == -EREMOTE)
+ rc = 0;
  if (rc) {
  cifs_dbg(FYI, "%s: Get mode from SID failed. rc=%d\n",
  __func__, rc);
@@ -1025,6 +1027,8 @@ cifs_get_inode_info(struct inode **inode,
  } else if (cifs_sb->mnt_cifs_flags & CIFS_MOUNT_CIFS_ACL) {
  rc = cifs_acl_to_fattr(cifs_sb, &fattr, *inode, false,
  full_path, fid);
+ if (rc == -EREMOTE)
+ rc = 0;
  if (rc) {
  cifs_dbg(FYI, "%s: Getting ACL failed with error: %d\n",
  __func__, rc);