Fixed a bug in TorchPackage macro arguments test #558
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.. "if ($src)" does not work if $src i a macro, as cmake does not consider macro argument to be a variable (!). So only the case that had an upper scope variables named $src and luasrc worked before.
Also, C linker language specified for sources as CMake gets lost if all sources are .cu CUDA files
So now cunn can use ADD_TORCH_PACKAGE macro (used to break on both issues above)