-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Oya secrets for windows #71
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 6 of 6 files at r1, 1 of 1 files at r2.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @bart84ek)
go.mod, line 49 at r1 (raw file):
github.com/ianlancetaylor/demangle v0.0.0-20181102032728-5e5cf60278f6 // indirect github.com/imdario/mergo v0.3.7 // indirect github.com/inconshreveable/mousetrap v1.0.0 // indirect
Is this used?
cmd/internal/secrets.go, line 29 at r1 (raw file):
cmd.Stdout = stdout // os.Stdout cmd.Stderr = stderr // os.Stderr return cmd.Run()
Is this now enough to run it on Un*x now? I believe you it's just it's unbelievable that it was needed before and not now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @bart84ek and @bilus)
cmd/internal/secrets.go, line 29 at r1 (raw file):
Previously, bilus (Marcin Bilski) wrote…
Is this now enough to run it on Un*x now? I believe you it's just it's unbelievable that it was needed before and not now.
It works!
I'm not sure why we ended up with so complicated solution.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @bilus)
go.mod, line 49 at r1 (raw file):
Previously, bilus (Marcin Bilski) wrote…
Is this used?
i think so
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! all files reviewed, all discussions resolved
This change is