Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

`Writer' protocol change. #74

Merged
merged 1 commit into from
Jan 13, 2019
Merged

`Writer' protocol change. #74

merged 1 commit into from
Jan 13, 2019

Conversation

tonystone
Copy link
Owner

  • Added LogEntry tuple type to Writer defining the formal types that a Writer writes.
  • Changed Writer protocol log(timestamp:level:tag:message:runtimeContext:staticContext:) method to write(_ entry: Writer.LogEntry) to make it easier to process messages by writers and formatters.

…text:staticContext:)` method to `write(_ entry: Writer.LogEntry)` to make it easier to process messages by writers and formatters.
@codecov
Copy link

codecov bot commented Jan 13, 2019

Codecov Report

Merging #74 into release-5.0 will increase coverage by <.01%.
The diff coverage is 100%.

@@               Coverage Diff               @@
##           release-5.0      #74      +/-   ##
===============================================
+ Coverage        99.13%   99.13%   +<.01%     
===============================================
  Files               22       22              
  Lines              576      578       +2     
===============================================
+ Hits               571      573       +2     
  Misses               5        5
Impacted Files Coverage Δ
Sources/TraceLog/Logger.swift 87.09% <ø> (ø) ⬆️
Sources/TraceLog/Formatters/JSONFormat.swift 100% <100%> (ø) ⬆️
Sources/TraceLogTestHarness/BufferReader.swift 100% <100%> (ø) ⬆️
Sources/TraceLogTestHarness/BufferWriter.swift 100% <100%> (ø) ⬆️
Sources/TraceLog/Writers/FileWriter.swift 100% <100%> (ø) ⬆️
Sources/TraceLog/Proxies/AsyncWriterProxy.swift 100% <100%> (ø) ⬆️
Sources/TraceLog/Formatters/TextFormat.swift 100% <100%> (ø) ⬆️
Sources/TraceLog/Proxies/SyncWriterProxy.swift 100% <100%> (ø) ⬆️
Sources/TraceLogTestHarness/TestHarness.swift 100% <100%> (ø) ⬆️
Sources/TraceLog/Writers/ConsoleWriter.swift 100% <100%> (ø) ⬆️
... and 1 more

@tonystone tonystone merged commit 400f6bb into release-5.0 Jan 13, 2019
@tonystone tonystone deleted the tuple-log-entry branch January 13, 2019 20:05
tonystone added a commit that referenced this pull request Jan 13, 2019
…ering

* 'release-5.0' of github.com:tonystone/tracelog:
  Changed `Writer` protocol (#74)

# Conflicts resolved:
#	Sources/TraceLog/Proxies/AsyncWriterProxy.swift
#	Sources/TraceLog/Proxies/DirectWriterProxy.swift
#	Sources/TraceLog/Proxies/SyncWriterProxy.swift
#	Sources/TraceLog/Writer.swift
#	Sources/TraceLog/Writers/ConsoleWriter.swift
#	Sources/TraceLog/Writers/FileWriter.swift
#	Sources/TraceLogTestHarness/BufferWriter.swift
#	Tests/TraceLogTests/TestWriters/CallbackTestWriter.swift
#	Tests/TraceLogTests/TestWriters/FailWhenFiredTestWriter.swift
#	Tests/TraceLogTests/TestWriters/SleepyTestWriter.swift
#	Tests/TraceLogTests/TestWriters/ValidateExpectedValuesTestWriter.swift
#	Tests/TraceLogTests/TraceLogPerformanceTests.swift
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant