Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Swift 2.2 syntax #19

Merged
merged 4 commits into from
Apr 25, 2016
Merged

Update to Swift 2.2 syntax #19

merged 4 commits into from
Apr 25, 2016

Conversation

phchang
Copy link
Collaborator

@phchang phchang commented Apr 24, 2016

No description provided.

@phchang
Copy link
Collaborator Author

phchang commented Apr 25, 2016

The CI failure seems to be the same as this issue: travis-ci/travis-ci#3986

@tonystone
Copy link
Owner

@phchang See my comments in this thread concerning the same issue travis-ci/travis-ci#5743 (comment)

Can you update the TraceLog travis.yml to be the same structure as GeoFeatures 1 here https://github.com/tonystone/geofeatures/blob/master/.travis.yml

You don't have to include the global: - COCOAPODS_DISABLE_DETERMINISTIC_UUIDS=1 but the rest should pretty much be exactly the same accept for the name of the project and scheme.

@@ -1,20 +1,20 @@
language: objective-c
xcode_workspace: Example/TraceLog.xcworkspace
xcode_scheme: TraceLog-Example
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@phchang can you switch out xcode_workspace: and xcode_scheme: here for os: osx as it is in GeoFeatures 1? These are redundant and don't need to be here, just more for us to maintain and keep in sync.

@tonystone
Copy link
Owner

Approved, all clear to merge @phchang.

@phchang phchang merged commit 1df3652 into master Apr 25, 2016
@phchang phchang deleted the update-swift-syntax branch April 25, 2016 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants