Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buffer writer fix #105

Merged
merged 2 commits into from
Oct 12, 2020
Merged

Buffer writer fix #105

merged 2 commits into from
Oct 12, 2020

Conversation

tonystone
Copy link
Owner

@tonystone tonystone commented Oct 8, 2020

Description

Fixing a crash when buffering is on and the buffer is empty when it attempts to write.

Motivation and Context

How Has This Been Tested?

This fix is currently being tested in a pre-release application during the QA cycle.

Checklist:

For all changes:

  • Is there an issue associated with this PR? Is it referenced
    in the commit message?
  • Has your PR been rebased against the latest commit within the target branch (typically master)?
  • Is your initial contribution a single, squashed commit?

For code changes:

  • Avoid other runtime dependencies
  • Have you written or updated unit tests to verify your changes?
  • Have you ensured that the full suite of tests is executed via make tests in the cmake-build-debug` directory off the root of the project?
  • If applicable, have you updated the documentation?
  • If applicable, have you updated the CHANGELOG.md file?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

@tonystone tonystone merged commit db633b7 into master Oct 12, 2020
@tonystone tonystone deleted the buffer-writer-fix branch April 8, 2022 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants