Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Console writer and newlines #55

Closed
dominik-hadl opened this issue Sep 9, 2018 · 4 comments
Closed

Console writer and newlines #55

dominik-hadl opened this issue Sep 9, 2018 · 4 comments
Assignees
@tonystone
Labels
bug

Comments

@dominik-hadl
Copy link

Should ConsoleWriter output a newline at the end of each log? Or is it intended to work that way?
@tonystone
Copy link
Owner

tonystone commented Sep 9, 2018 •
edited
Loading

Hi Nick, it is intended to have a newline at the end. It looks like we lost that on the ConsoleWriter in the last release when we switched from print to standardOutput.write. I'll get that fixed asap and get a point release out.

Thanks for bringing that to our attention.

@tonystone tonystone added the bug label Sep 9, 2018
@tonystone tonystone self-assigned this Sep 9, 2018
tonystone added a commit that referenced this issue Sep 9, 2018
@tonystone
Issue #55: Update ConsoleWriter adding newline at the end of the mess…
4b1872c 
…age before writing to standardOutout.
@dominik-hadl
Copy link
Author

dominik-hadl commented Sep 10, 2018 •
edited
Loading

@tonystone Amazingly fast response and fix. Great (frame)work 👍

tonystone added a commit that referenced this issue Sep 10, 2018
@tonystone
Add direct ConsoleWriter tests (also validates issue #55)
dd8018f
tonystone added a commit that referenced this issue Sep 10, 2018
@tonystone
Merge pull request #56 from tonystone/issue-55
a629845 
Issue #55: Update ConsoleWriter adding newline
@tonystone tonystone mentioned this issue Sep 10, 2018
Merged
@tonystone
Copy link
Owner

@NickSkull Tagged it 4.0.1. Use that version for SPM, or if you are using CocoaPods, I also pushed 4.0.1 to the trunk, so that is all ready for you as well.

Let me know if you have any other issues. Also, if we're all clear with this one, let me know, and I'll close it out.

@dominik-hadl
Copy link
Author

All good, thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tonystone tonystone

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dominik-hadl @tonystone