Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Lint startup error on 0.6 #224

Merged
merged 1 commit into from
Apr 23, 2017
Merged

Fix Lint startup error on 0.6 #224

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fix Lint startup error on 0.6
  • Loading branch information
@TotalVerb
TotalVerb committed Apr 23, 2017
commit 7fd9db725ec9bfca60bbff2cccac35a0f7db237e
6 changes: 2 additions & 4 deletions src/knowndeprec.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ function parseDeprecate(ex, lineabs)
end
end

function getFuncNameAndSig(callex::Expr, strict::Bool=true)
function getFuncNameAndSig(callex::Expr)
typeHints = Dict{Symbol, Any}()
if typeof(callex.args[1])==Symbol || Meta.isexpr(callex.args[1], :(.))
funcname = callex.args[1]
Expand All @@ -151,8 +151,6 @@ function getFuncNameAndSig(callex::Expr, strict::Bool=true)
# these kinds of call overloads are hard to understand
# so for now, just ignore them
return (nothing, nothing)
elseif strict
error("invalid function format $callex")
else
return (nothing, nothing)
end
Expand Down Expand Up @@ -191,7 +189,7 @@ end
# returns nothing, or DeprecateInfo
function functionIsDeprecated(callex::Expr)
global deprecates
funcname, sig = getFuncNameAndSig(callex, false)
funcname, sig = getFuncNameAndSig(callex)
if Meta.isexpr(funcname, :(.))
funcname = funcname.args[2]
end
Expand Down