-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated React to 0.13 and added context methods. #37
Conversation
I think
|
@ajchemist are you saying I tried those two commands and there was no change, according to git. |
Oops. try this,
or
|
Good catch, thanks. |
Great! But it seems you missed -s examples on
line. https://github.com/currentoor/rum/blob/eef3efa2b6ed2a2d6ecf3579cdb257124de82552/target/main.js#L281 maybe ended with
|
Oops, already known issue #35. But compling with
|
Ok compiled and verified that the examples work. |
good work! I ran into this same problem the other day and just decided to use reagent, because laziness. |
@atroche Thanks! I'll hopefully have a rum-material-ui wrapper on cljsjs before the end of the weekend. Don't join the dark side yet! |
Context methods are being used by React libraries like material-ui but they were not in the Rum API.