Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error/warning when unrecognised keys are passed in mixin #96

Closed
martinklepsch opened this issue Sep 8, 2016 · 2 comments
Closed

Error/warning when unrecognised keys are passed in mixin #96

martinklepsch opened this issue Sep 8, 2016 · 2 comments

Comments

@martinklepsch
Copy link
Contributor

If people have a typo in their mixin keys things will silently fail. Would you be open to a PR that logs a warning or similar when an unknown key is passed as part of a mixin map?

@tonsky
Copy link
Owner

tonsky commented Sep 9, 2016

I’d say more: we should leverage schema for that, probably. At least after 1.9 is out of the door

@martinklepsch
Copy link
Contributor Author

Not sure about intrusions a dependency (schema or spec for that matter) for
this particular thing but great that you're also on board about making that
a little better :)

(I know spec isn't really a dependency but it's still somewhat alpha, might
have unexpected effects on code size etc so I'm more in favor of a simple
subset check)
On Sat, 10 Sep 2016 at 00:45, Nikita Prokopov [email protected]
wrote:

I’d say more: we should leverage schema for that, probably. At least after
1.9 is out of the door


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#96 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAF82J92NZy5MOSDTK0q4LpOYo-E5aBOks5qodOBgaJpZM4J4IZP
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants