Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Server side rendering requires Sablono and transitively Clojurescript. #83

Closed
prathyvsh opened this issue Jul 6, 2016 · 1 comment
Closed

Server side rendering requires Sablono and transitively Clojurescript. #83

prathyvsh opened this issue Jul 6, 2016 · 1 comment

Comments

@prathyvsh
Copy link

prathyvsh commented Jul 6, 2016 •
edited
Loading

Posting as requested on Twitter: https://twitter.com/prathyvsh/status/750641432386367489

Using rum.core/render-static-markup solely for server side rendering leads to import of Clojurescript.
Excluding Clojurescript is a no go since Sablono is being pulled in on the core ns.

This can be remedied by using
[rum "0.10.3" :only [server-render]]
on import.

But a better solution could be out there.
stephen144 added a commit to stephen144/rum that referenced this issue Jan 11, 2018
@stephen144
README - small clarification
eb562e4 
README says server-side rendering doesn't need cljs. There is currently an issue open about that (see tonsky#83).
@stephen144 stephen144 mentioned this issue Jan 11, 2018
Closed
@tonsky tonsky closed this as completed in 38017b5 Feb 10, 2018
@tonsky
Copy link
Owner

tonsky commented Feb 10, 2018

Fixed in 0.11.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tonsky @prathyvsh