lib: add name to floating IPs

tonobo · Jun 22, 2023 · a025edc · a025edc
1 parent 30c037b
commit a025edc
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 4 deletions.
diff --git a/lib/hcloud/floating_ip.rb b/lib/hcloud/floating_ip.rb
@@ -12,7 +12,7 @@ class FloatingIP
  )
 
  protectable :delete
- updatable :description
+ updatable :name, :description
  destructible
 
  has_actions

diff --git a/lib/hcloud/floating_ip_resource.rb b/lib/hcloud/floating_ip_resource.rb
@@ -13,7 +13,7 @@ def [](arg)
  end
  end
 
- def create(type:, server: nil, home_location: nil, description: nil, labels: {})
+ def create(type:, name: nil, server: nil, home_location: nil, description: nil, labels: {})
  raise Hcloud::Error::InvalidInput, 'no type given' if type.blank?
  if server.nil? && home_location.nil?
  raise Hcloud::Error::InvalidInput, 'either server or home_location must be given'

diff --git a/spec/hcloud/floating_ip_spec.rb b/spec/hcloud/floating_ip_spec.rb
@@ -47,11 +47,13 @@
  it 'works' do
  params = {
  type: 'ipv4',
+ name: 'moo',
  home_location: 'fsn1',
  labels: { 'key' => 'value', 'novalue' => '' }
  }
  response_params = {
  type: params[:type],
+ name: params[:name],
  home_location: floating_ip[:home_location],
  labels: params[:labels]
  }
@@ -64,14 +66,13 @@
  expect(key.id).to be_a Integer
  expect(key.name).to be_a String
  expect(key.type).to eq('ipv4')
+ expect(key.name).to eq('moo')
  expect(key.home_location).to be_a Hcloud::Location
  expect(key.created).to be_a Time
  expect(key.labels).to eq(params[:labels])
  end
 
  it 'validates uniq name' do
- pending 'Implementation of floating IP does not support name, yet'
-
  stub_error(:floating_ips, :post, 'uniqueness_error', 409)
 
  expect do