[FLINK-9026] [flip6] Close the TaskManagerMetricGroup when the TaskEx…

…ecutor is shut down This closes apache#5734.
tongcheng-elong · Mar 28, 2018 · 7a21efb · 7a21efb
1 parent 066b66d
commit 7a21efb
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskExecutor.java b/flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskExecutor.java
@@ -292,6 +292,9 @@ public CompletableFuture<Void> postStop() {
  throwable = ExceptionUtils.firstOrSuppressed(t, throwable);
  }
 
+ // it will call close() recursively from the parent to children
+ taskManagerMetricGroup.close();
+
  if (throwable != null) {
  return FutureUtils.completedExceptionally(new FlinkException("Error while shutting the TaskExecutor down.", throwable));
  } else {