[hotfix][ci] Use static methods

tongcheng-elong · May 11, 2021 · 0fcf44e · 0fcf44e
1 parent 35ca4cf
commit 0fcf44e
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 5 deletions.
diff --git a/...ci/java-ci-tools/src/main/java/org/apache/flink/tools/ci/licensecheck/LicenseChecker.java b/...ci/java-ci-tools/src/main/java/org/apache/flink/tools/ci/licensecheck/LicenseChecker.java
@@ -39,11 +39,9 @@ public static void main(String[] args) throws Exception {
  LOG.warn(
  "THIS UTILITY IS ONLY CHECKING FOR COMMON LICENSING MISTAKES. A MANUAL CHECK OF THE NOTICE FILES, DEPLOYED ARTIFACTS, ETC. IS STILL NEEDED!");
 
- NoticeFileChecker noticeChecker = new NoticeFileChecker();
- int severeIssueCount = noticeChecker.run(new File(args[0]), Paths.get(args[1]));
+ int severeIssueCount = NoticeFileChecker.run(new File(args[0]), Paths.get(args[1]));
 
- JarFileChecker jarChecker = new JarFileChecker();
- severeIssueCount += jarChecker.checkPath(Paths.get(args[2]));
+ severeIssueCount += JarFileChecker.checkPath(Paths.get(args[2]));
 
  if (severeIssueCount > 0) {
  LOG.warn("Found a total of {} severe license issues", severeIssueCount);

diff --git a/...java-ci-tools/src/main/java/org/apache/flink/tools/ci/licensecheck/NoticeFileChecker.java b/...java-ci-tools/src/main/java/org/apache/flink/tools/ci/licensecheck/NoticeFileChecker.java
@@ -70,7 +70,7 @@ public class NoticeFileChecker {
  Pattern.compile(
  "- ([^ :]+):([^:]+):([^ ]+)($| )|.*bundles \"([^:]+):([^:]+):([^\"]+)\".*");
 
- int run(File buildResult, Path root) throws IOException {
+ static int run(File buildResult, Path root) throws IOException {
  int severeIssueCount = 0;
  // parse included dependencies from build output
  Multimap<String, IncludedDependency> modulesWithBundledDependencies =