Keys should be identifier-like (addresses #65) #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keys should contain only letters, numbers or underscore (`_`) characters, and should start with a letter or underscore. See toml-lang#65 for discussion.
|
In Lisps hyphens are more idiomatic than underscores. Maybe both should be supported. Or maybe a Lisp implementation should turn |
|
A good suggestion. Everything has a limit! 😃 |
|
I would stick with just |
|
Nice @parkr, I agree... |
|
I'm in favour of letters, numbers, underscores, and hyphens. |
Closed
|
See #65 (comment) |
|
An alternative was merged in #283. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keys should contain only letters, numbers or underscore (
_) characters, and shouldstart with a letter or underscore. See #65 for discussion.