Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adds PowerBi Dedicated scraping #2368

Merged
merged 32 commits into from
Sep 3, 2023

Conversation

SurtzSean
Copy link
Contributor

@SurtzSean SurtzSean commented Aug 21, 2023

When implementing a new scraper; these tasks are completed:

Metrics output:

src-promitor.agents.scraper-1            | [03:35:00 INF] Found value 9 for metric azure_powerbi_dedicated_cpu_usage with aggregation interval 00:05:00

Screen Shot 2023-08-26 at 11 32 56 PM

Discovery output:

src-promitor.agents.scraper-1            | [03:35:00 INF] Discovered 1 resources for resource collection powerbi-dedicated.

Relates to #339
Relates to promitor/docs#54

@trafico-bot trafico-bot bot added the 🔍 Ready for Review Pull Request is not reviewed yet label Aug 21, 2023
@CLAassistant
Copy link

CLAassistant commented Aug 21, 2023

CLA assistant check
All committers have signed the CLA.

@github-actions
Copy link

Thank you for your contribution! 🙏 We will review it as soon as possible.

@SurtzSean SurtzSean changed the title feat: adds PowerBi Embedded scraping feat: adds PowerBi Dedicated scraping Aug 26, 2023
@SurtzSean
Copy link
Contributor Author

@tomkerkhove this has been updated to use PowerBidedicated everywhere except for ResourceType

@SurtzSean
Copy link
Contributor Author

@tomkerkhove I'm unsure about the build failure message as I ran and tested e2e locally. Is it a problem with the pipeline, or PR?

@SurtzSean
Copy link
Contributor Author

/azp run Promitor CI - Scraper Agent

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 2368 in repo tomkerkhove/promitor

@SurtzSean
Copy link
Contributor Author

@tomkerkhove would you be able to take a look if you get a moment, or would there be anything more you need prior?

@tomkerkhove
Copy link
Owner

Nope, should be good - I'll take a look when I can.

@tomkerkhove
Copy link
Owner

/azp run Promitor CI - Scraper Agent

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Owner

@tomkerkhove tomkerkhove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but some comments were added - The scraper type is the main required change.

Thanks for the contribution!

@trafico-bot trafico-bot bot added 🔍 Ready for Review Pull Request is not reviewed yet and removed ⚠️ Changes requested Pull Request needs changes before it can be reviewed again labels Sep 2, 2023
@SurtzSean
Copy link
Contributor Author

@tomkerkhove I believe I responded to all feedback

Copy link
Owner

@tomkerkhove tomkerkhove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, sorry for the slow reviews and thanks for the contribution!

changelog/content/experimental/unreleased.md Outdated Show resolved Hide resolved
@trafico-bot trafico-bot bot added ✅ Approved Pull Request has been approved and can be merged and removed 🔍 Ready for Review Pull Request is not reviewed yet labels Sep 3, 2023
@trafico-bot trafico-bot bot added the 🔍 Ready for Review Pull Request is not reviewed yet label Sep 3, 2023
@trafico-bot trafico-bot bot removed the ✅ Approved Pull Request has been approved and can be merged label Sep 3, 2023
@tomkerkhove tomkerkhove merged commit cd6a338 into tomkerkhove:master Sep 3, 2023
26 of 28 checks passed
@trafico-bot trafico-bot bot added ✨ Merged Pull Request has been merged successfully and removed 🔍 Ready for Review Pull Request is not reviewed yet labels Sep 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Merged Pull Request has been merged successfully
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants