-
-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adds PowerBi Dedicated scraping #2368
Conversation
Thank you for your contribution! 🙏 We will review it as soon as possible. |
@tomkerkhove this has been updated to use PowerBidedicated everywhere except for ResourceType |
@tomkerkhove I'm unsure about the build failure message as I ran and tested e2e locally. Is it a problem with the pipeline, or PR? |
/azp run Promitor CI - Scraper Agent |
Commenter does not have sufficient privileges for PR 2368 in repo tomkerkhove/promitor |
@tomkerkhove would you be able to take a look if you get a moment, or would there be anything more you need prior? |
Nope, should be good - I'll take a look when I can. |
/azp run Promitor CI - Scraper Agent |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but some comments were added - The scraper type is the main required change.
Thanks for the contribution!
config/promitor/resource-discovery/resource-discovery-declaration.yaml
Outdated
Show resolved
Hide resolved
...Agents.Scraper/Validation/MetricDefinitions/ResourceTypes/PowerBiDedicatedMetricValidator.cs
Outdated
Show resolved
Hide resolved
...mitor.Core.Scraping/Configuration/Serialization/v1/Providers/PowerBiDedicatedDeserializer.cs
Outdated
Show resolved
Hide resolved
src/Promitor.Tests.Unit/Serialization/v1/Providers/PowerBiDedicatedTests.cs
Show resolved
Hide resolved
...tion/Scraper/Metrics/ResourceTypes/PowerBiDedicatedMetricsDeclarationValidationStepsTests.cs
Show resolved
Hide resolved
...tion/Scraper/Metrics/ResourceTypes/PowerBiDedicatedMetricsDeclarationValidationStepsTests.cs
Outdated
Show resolved
Hide resolved
@tomkerkhove I believe I responded to all feedback |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, sorry for the slow reviews and thanks for the contribution!
When implementing a new scraper; these tasks are completed:
don't know if links will be correct
Metrics output:
Discovery output:
Relates to #339
Relates to promitor/docs#54