Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/issues/27: added display block/none so nav is centered until smaller logo shows + fix for nav being crushed when nav items are larger words #68

Closed
wants to merge 3 commits into from

Conversation

NorseGaud
Copy link

@NorseGaud NorseGaud commented Jun 5, 2019

#27

And...

Old ----
Screen Shot 2019-05-27 at 8 09 24 PM
Screen Shot 2019-05-27 at 8 01 24 PM

New ----
Screen Shot 2019-05-27 at 8 09 17 PM
Screen Shot 2019-05-27 at 8 01 36 PM

@NorseGaud NorseGaud changed the title /issues/27: added display block/none so nav is centered until smaller logo shows /issues/27: added display block/none so nav is centered until smaller logo shows + fix for nav being crushed when nav items are larger words Jun 5, 2019
@NorseGaud
Copy link
Author

@tomanistor Any updates on the review?

@tomanistor
Copy link
Owner

tomanistor commented Jun 14, 2019

Hi @NorseGaud I don't have much time right now but I will get to it. Ideally, I'd like to develop a solution that doesn't wrap the menu on two lines.

Maybe I'd need to trigger the mobile menu quicker when there is no room to display all menu items on one line. This might require custom breakpoints from project to project since everyone will have a different amount of menu items of varying length.

@NorseGaud NorseGaud closed this Jun 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants