Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for incorrect section name in conditional and broken JavaScript for Basin form #56

Merged
merged 2 commits into from
Dec 20, 2018

Conversation

joeraut
Copy link
Contributor

@joeraut joeraut commented Dec 11, 2018

Resolution of two issues I'd experienced:

  • Incorrect section being used inside the conditional for determining whether to display the gallery or not in index.html - the length of blog was used instead of gallery. The gallery is not displayed when blog posts aren't present.
  • The Basin form JavaScript logic wasn't working on Safari on macOS/iPhone - nothing would happen after 'Send' was pressed. The closing ] bracket was missing within the strings for the following two expressions:
    i=e("input[name=email").value,a=e("input[name=_subject")
    I just inserted the missing ] brackets.

@tomanistor
Copy link
Owner

Thanks a lot for catching those mistakes and correcting them @joeraut, I appreciate it!

That second error is a bit worrying - I'm not sure why that file wasn't minified correctly.

@tomanistor tomanistor merged commit f053207 into tomanistor:master Dec 20, 2018
@tomanistor
Copy link
Owner

Ah, I found the problem. The contact.js source file contained the error initially:

I'll send along a fix for that to prevent this error from popping up again in the future when the minified file is regenerated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants