Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/images/logo/manifest.json? #16

Closed
TheHackerDev opened this issue Sep 14, 2017 · 2 comments
Closed

/images/logo/manifest.json? #16

TheHackerDev opened this issue Sep 14, 2017 · 2 comments

Comments

@TheHackerDev
Copy link

The theme tries to load /images/logo/manifest.json here, but it does not include this file anywhere. What is this for?

Cheers,
Aaron (insp3ctre)

@tomanistor
Copy link
Owner

Hey @insp3ctre, that is the manifest.json file used for Android Chrome to add a favicon icon to the homescreen.

https://developer.chrome.com/multidevice/android/installtohomescreen#supporting

It is not included in the site build but it should be created by the developer when uploading favicons for their site.

However, I didn't include instructions for that and it really shouldn't be automatically added in like it currently is. That whole favicon section should be rewritten, so thank you for bringing it up!

@TheHackerDev
Copy link
Author

No problem, thanks for the quick turnaround!

bangfalse added a commit to bangfalse/osprey that referenced this issue Mar 9, 2018
* 'master' of https://github.com/tomanistor/osprey: (24 commits)
  Moved scripts from footer into body-bottom, fixed issue tomanistor#36 - scrolling when full screen nav is active
  Removed jQuery from contact form, minor styling adjustments
  Contact form thank you message
  Created contact partial for homepage footer
  Started removing jQuery from contact.js
  Removed jQuery from index.js
  Stared removing jQuery and reorganizing partials
  Fixed the Favicon reference
  Disable the contact form if Formspree is not used
  Linting fix.
  Modify icon link to not reload page.
  Fixes link to License
  Fixed tomanistor#16, tomanistor#17, tomanistor#18, and changed hash.json to assetsManifest.json
  Fixed contact form message jQuery selector
  Refactored gallery build
  Fixed gallery build bug
  Fixed gallery build bug
  Saved gallery progress
  Save gallery work
  Updated README
  ...
joeraut pushed a commit to joeraut/osprey that referenced this issue Jan 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants