Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Looking for advanced OMV users #104

Open
tomaae opened this issue Apr 16, 2023 · 31 comments
Open

Looking for advanced OMV users #104

tomaae opened this issue Apr 16, 2023 · 31 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@tomaae
Copy link
Owner

tomaae commented Apr 16, 2023

I'm looking for advanced OMV users who could help me implement plugins and some omv-extras.
What I'm looking for is help setting up those OMV features in a way most people use them or provide necessery API outputs from live system.

List of plugins that look interesting for HA integration:
openmediavault-compose (Docker) - Done / Separate portainer integration https://github.com/tomaae/homeassistant-portainer
openmediavault-kvm (VM) - Done
openmediavault-cputemp - Crashed integration if sensor is not available on OS
openmediavault-diskstats - rdd, may not be possible

openmediavault-downloader
openmediavault-nut (UPS)
openmediavault-tgt (iSCSI)
openmediavault-zfs

@tomaae tomaae added enhancement New feature or request help wanted Extra attention is needed labels Apr 16, 2023
@tomaae tomaae pinned this issue Apr 16, 2023
@BebeMischa
Copy link

I'm so happy seeing, that you, even without using OMV yourself, are still putting time in this integration. So nice of of you!

And I would like to help out, as far, as I can. The trouble here is, I'm all, but no advanced. If I can help you somehow, I will need guidance.
I have cputemp and diskstats installed. But I do know nothing about the API. But I'm able to follow instructions.

So, if I can help you with SSH into the machine, enter a command and get some output, I would happily do that.

@tomaae
Copy link
Owner Author

tomaae commented Apr 17, 2023

I'm so happy seeing, that you, even without using OMV yourself, are still putting time in this integration. So nice of of you!

And I would like to help out, as far, as I can. The trouble here is, I'm all, but no advanced. If I can help you somehow, I will need guidance. I have cputemp and diskstats installed. But I do know nothing about the API. But I'm able to follow instructions.

So, if I can help you with SSH into the machine, enter a command and get some output, I would happily do that.

No need to know API, just helping me configuring OMV in my develoment environment is enough.
cputemp and diskstat are probably most easy ones, I just need to see if there is anything to confugure from OMV side and where are the information for those/what is useful to have in HA.
Since it has been years since last I used OMV, I know very little about new versions. Also, with having VM only, I cant test things like cputemp most likely.

@tomaae
Copy link
Owner Author

tomaae commented Apr 19, 2023

testing current master would be helpful too. it went through major rework so there may be issues.
I have it running nonstop on my QA envinroment with simulated load, but that is just not the same.

@BebeMischa
Copy link

Installed MASTER now. As far as I see in the first 10 minutes, all looks OK. I will report, if something goes wrong, making a separate issue. There is one minor issue, but that has been there in last normal version also, will make new issue for that.
And, MASTER still does not see "Update's available".

afbeelding

@tomaae
Copy link
Owner Author

tomaae commented Apr 20, 2023

Update sensor does work in master, I have tested it. It broke because omv changed it grin binary value to number of updates available.

@BebeMischa
Copy link

afbeelding

afbeelding

Maybe have to wait a little longer?

@tomaae
Copy link
Owner Author

tomaae commented Apr 20, 2023

image
Works for me. You even have same OMV version I do based on other ticket. We will need to debug this one too to figure out whats happening.

@tomaae
Copy link
Owner Author

tomaae commented Apr 20, 2023

I will need help with openmediavault-cputemp, cant simulate it within proxmox.

@BebeMischa
Copy link

BebeMischa commented Apr 25, 2023

Tell me, what to do about CPU temp... ;-)

And I'm making an issue about the update sensor...

@tomaae
Copy link
Owner Author

tomaae commented Apr 25, 2023

Tell me, what to do about CPU temp... ;-)

And I'm making an issue about the update sensor...

Can you tell me where in OMV UI I can find info from these 2?
openmediavault-cputemp
openmediavault-diskstats

I can probably look up code I need you to run based on that.

@BebeMischa
Copy link

BebeMischa commented Apr 25, 2023

CPUtemp can, as I know, only be added to your Dashboard. Click right upper corner the person symbol (user settings), click dashboard, check CPUtemp, click save.
It will appear on the dashboard.
(Note, a lot of people complain on OMV forum, that the sensor does not work. Mine does not work also, it shows 29 Celsius always)

Diskstats under diagnostics - performance statistics- disk usage.

@tomaae
Copy link
Owner Author

tomaae commented Apr 25, 2023

can you run latest master and look into log? there should be entry CpuTemp with something.
no need to run as debug, its regular print.
for me it just show "CpuTemp: None", but thats probably because I'm using VM.

@tomaae
Copy link
Owner Author

tomaae commented Apr 25, 2023

Actually, cputemp will return code 500, so it will keep crashing integration if its not available. so we may have to skip on that sensor

@tomaae
Copy link
Owner Author

tomaae commented Apr 27, 2023

@BebeMischa do we have any showstoppers for a release right now?

@BebeMischa
Copy link

Not on my system, as far as I see... ;-)

@tomaae
Copy link
Owner Author

tomaae commented Apr 27, 2023

1.4.0 is out now, been a while since last release.
Now it will be about new features.

@slakouz
Copy link

slakouz commented Apr 27, 2023

Please add cputemp back as an option. It is important thing for me. This plugin working fine in my raspberry omv installation. To monitor omv cputemp from my HA host I'm using legacy SSH console command integration which has not reliable functionality. So if your integration will support cputemp then I will remove that obsolete integration. Thank you!

@tomaae
Copy link
Owner Author

tomaae commented Apr 27, 2023

Please add cputemp back as an option. It is important thing for me. This plugin working fine in my raspberry omv installation. To monitor omv cputemp from my HA host I'm using legacy SSH console command integration which has not reliable functionality. So if your integration will support cputemp then I will remove that obsolete integration. Thank you!

cant do that as it returns code 500 when sensor is not available. that crashes api.

@BebeMischa
Copy link

Just a confirm - 1.4.1 works fine here too ;-)

@tomaae
Copy link
Owner Author

tomaae commented Apr 27, 2023

oh yea, it should. its just permanent fix for any kind of weird inputs that are supposed to be integer or float.
learned a lesson, can't trust OMV API :)

@slakouz
Copy link

slakouz commented Apr 28, 2023

Please add cputemp back as an option. It is important thing for me. This plugin working fine in my raspberry omv installation. To monitor omv cputemp from my HA host I'm using legacy SSH console command integration which has not reliable functionality. So if your integration will support cputemp then I will remove that obsolete integration. Thank you!

cant do that as it returns code 500 when sensor is not available. that crashes api.

it can be a (switched off by default) option in integration settings. So only specific users may turn on if required

@tomaae
Copy link
Owner Author

tomaae commented May 3, 2023

I see compose integration is pretty much useless and probably not used much.
I think we may need separate docker/portainer integration, as it is not really integrated into OMV and could be useful in other setups.

@tomaae
Copy link
Owner Author

tomaae commented May 3, 2023

@slakouz
Cant have plugin that crushes integration like that. I will gladly implement it once plugin returns correct data/no data with error, instead of internal server error code.
Code 500 is supposed to mean that application server crashed, or similar. Not that there are no data.
If you know how to report it to community plugin people/plugin code owner, feel free to do so and link the issue/PR here.

@BebeMischa
Copy link

usual place to report issues is here https://forum.openmediavault.org/ ;-)

@tomaae
Copy link
Owner Author

tomaae commented May 3, 2023

usual place to report issues is here https://forum.openmediavault.org/ ;-)

its community plugin, not official one, right?

@BebeMischa
Copy link

I just don't know of any other place :-)

@tomaae
Copy link
Owner Author

tomaae commented May 3, 2023

I just don't know of any other place :-)

Probably on their github? Not sure about their support policy.

@BebeMischa
Copy link

BebeMischa commented May 3, 2023

The official bugtracker is here, but I'm not sure, if community addons are handled there too...

https://github.com/openmediavault/openmediavault/issues

@rlewis187
Copy link

Please add cputemp back as an option. It is important thing for me. This plugin working fine in my raspberry omv installation. To monitor omv cputemp from my HA host I'm using legacy SSH console command integration which has not reliable functionality. So if your integration will support cputemp then I will remove that obsolete integration. Thank you!

I monitor the CPU temp of my OMV server using an SSH sensor based on this:

https://community.home-assistant.io/t/how-to-monitor-proxmox-cpu-temp/245050

I have found it to be very reliable.

@slakouz
Copy link

slakouz commented May 4, 2023

Here is place to report issues for cputemp plugin
https://github.com/OpenMediaVault-Plugin-Developers/openmediavault-cputemp/issues
Sorry I can't report there because I was not see this issue in my system

@tomaae
Copy link
Owner Author

tomaae commented May 6, 2023

For those interested, since there is no docker/portainer integration into OMV UI/API, it cannot be part of this integration.
I have started planning on new docker integration, which will be using portainer API for security and compatibility reasons.
https://github.com/tomaae/homeassistant-portainer
If you are using portainer (not just on OMV) and are interested in testing/giving feedback, check this topic

Base concept is already done + endpoints sensors.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants