Addition of customField to chargeCard request parameters #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
November 4, 2019 13:19
|
@tolu360 taken a look yet? |
|
My bad, Stephen & Olayinka, I haven't I'm afraid - I have been super
swamped lately. Guys give me till sometime next week to review and possibly
merge.
…On Sat, Dec 7, 2019, 10:56 AM Stephen Amaza ***@***.***> wrote:
@tolu360 <https://github.com/tolu360> taken a look yet?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#42?email_source=notifications&email_token=AA53YZQ7LLTR3IXEQULDVIDQXNXNZA5CNFSM4JJTVTAKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEGGDAMI#issuecomment-562835505>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA53YZX3SOQBKYDK4A75KI3QXNXNZANCNFSM4JJTVTAA>
.
|
|
@tolu360 can you check this PR as it is needed extensively |
Added attrs to android folder
…ncy-versions upgraded android dependency versions
…ncy-versions updated
…ncy-versions removed the attr.xml file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello Tolu,
Thanks for creating this project. It helped me a lot as I've used it for almost all of my payment integration on apps.
Based on the issue I opened (here) on the inclusion of custom fields in the request parameter, I believe that the best way to predict the future is by creating it and thus, I'm glad to tell you that I've made some minor changes to your code and tested on both android and iOS and it works perfectly.
Screenshots are attached to this message for confirmation.
You can contact me on [email protected] for further details.
Regards