Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Java from 17 to 21 #2388

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Change Java from 17 to 21 #2388

wants to merge 11 commits into from

Conversation

M3rcena
Copy link

@M3rcena M3rcena commented Jun 25, 2024

It currently builds and run correctly using Java 21 so its a good update.

@JanCizmar
Copy link
Contributor

Hey! Why did you update the npm packages?

Copy link
Contributor

@JanCizmar JanCizmar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will also need to update the docker images to java 21. This is on me.

@M3rcena
Copy link
Author

M3rcena commented Jun 26, 2024

Hey! Why did you update the npm packages?

So they had severe vulnerabilities especially with the packages you use. It's a security flaw while they were outdated for a long time..

Also there is another security flaw which needs to be resolved. I will tell you in Slack while it's not good to mention it here

@M3rcena
Copy link
Author

M3rcena commented Jun 26, 2024

We will also need to update the docker images to java 21. This is on me.

Of course! I could do it but if you want it's all yours

@M3rcena
Copy link
Author

M3rcena commented Jun 26, 2024

We will also need to update the docker images to java 21. This is on me.

Also consider updating and changing the builder because it's deprecated with the latest Gradle versions.

@JanCizmar
Copy link
Contributor

What do you mean by the builder?

@M3rcena
Copy link
Author

M3rcena commented Jun 26, 2024

What do you mean by the builder?

If you go and build the docker image you will see you will get a Deprecated message for Gradle 9.0 because you have set the docker builder to 0. You need to either update the builder so it's not deprecated or use the docker builder itself, the builder kit

@JanCizmar
Copy link
Contributor

I cannot see update of Gradle in your PR. How are you actually running it?

@M3rcena
Copy link
Author

M3rcena commented Jun 26, 2024

I also removed jCenter()

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants